From 35d42ba1780aa7dcf03f8721de90f55176f7509b Mon Sep 17 00:00:00 2001
From: gwen <gwenaelremond@free.fr>
Date: Thu, 15 Jun 2023 16:29:31 +0200
Subject: [PATCH] install kedro

---
 README.md                  | 15 +++++++++++++++
 actes-princiers/.gitignore |  6 +++---
 2 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index 9e06e1a..a02e271 100644
--- a/README.md
+++ b/README.md
@@ -40,3 +40,18 @@ The project name 'Actes Princiers' has been applied to:
 - The project's python package in `datascience/actes-princiers/src/actes_princiers`
 
 A best-practice setup includes initialising git and creating a virtual environment before running 'pip install -r src/requirements.txt'
+
+Par rapport aux bonnes pratiques kedro 
+------------------------------------------
+
+Dans `actes-princiers/.gitignore`, 
+- les datas sont mises dans le dépôt git
+- le datacatalog en local est placé dans le dépôt git
+
+::
+
+    # ignore all local configuration
+    # conf/local/**
+    # ignore everything in the following folders
+    # data/**
+
diff --git a/actes-princiers/.gitignore b/actes-princiers/.gitignore
index 8cd10b4..e8b0c61 100644
--- a/actes-princiers/.gitignore
+++ b/actes-princiers/.gitignore
@@ -2,7 +2,7 @@
 # KEDRO PROJECT
 
 # ignore all local configuration
-conf/local/**
+# conf/local/**
 !conf/local/.gitkeep
 .telemetry
 
@@ -10,11 +10,11 @@ conf/local/**
 conf/**/*credentials*
 
 # ignore everything in the following folders
-data/**
+# data/**
 logs/**
 
 # except their sub-folders
-!data/**/
+#!data/**/
 !logs/**/
 
 # also keep all .gitkeep files